From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [RFC 3/5] bpf: fix validation of eal_divmod Date: Tue, 6 Nov 2018 13:48:59 -0800 Message-ID: <20181106214901.1392-4-stephen@networkplumber.org> References: <20181106214901.1392-1-stephen@networkplumber.org> Cc: Stephen Hemminger To: dev@dpdk.org Return-path: Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id D826A2D13 for ; Tue, 6 Nov 2018 22:49:07 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id g7-v6so4457727pfo.10 for ; Tue, 06 Nov 2018 13:49:07 -0800 (PST) In-Reply-To: <20181106214901.1392-1-stephen@networkplumber.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity spotted self assignment in BPF eval_divmod. This looks like a bug where the incoming source register should have been used instead. Coverity issue: 302850 Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program") Signed-off-by: Stephen Hemminger --- lib/librte_bpf/bpf_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.c index 83983efc4e5c..b768f72c4c02 100644 --- a/lib/librte_bpf/bpf_validate.c +++ b/lib/librte_bpf/bpf_validate.c @@ -512,7 +512,7 @@ eval_divmod(uint32_t op, struct bpf_reg_val *rd, struct bpf_reg_val *rs, if (op == BPF_MOD) rd->u.max = RTE_MIN(rd->u.max, rs->u.max - 1); else - rd->u.max = rd->u.max; + rd->u.max = rs->u.max; rd->u.min = 0; } -- 2.17.1