From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH] net/thunderx: fix Tx desc corruption in scatter-gather mode Date: Fri, 9 Nov 2018 08:20:15 +0000 Message-ID: <20181109082000.GA4934@jerin> References: <1541742633-798-1-git-send-email-nithin.dabilpuram@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Jacob, Jerin" , "Czekaj, Maciej" , "Nilla, Subrahmanyam" , "stable@dpdk.org" To: "Dabilpuram, Nithin" Return-path: In-Reply-To: <1541742633-798-1-git-send-email-nithin.dabilpuram@caviumnetworks.com> Content-Language: en-US Content-ID: <2FF7BDA79F5E0442B828618F2352B36E@namprd07.prod.outlook.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Fri, 9 Nov 2018 11:20:55 +0530 > From: "Dabilpuram, Nithin" > To: "dev@dpdk.org" , "Jacob, Jerin" > , "Czekaj, Maciej" > > CC: "Nilla, Subrahmanyam" , > "stable@dpdk.org" , "Dabilpuram, Nithin" > > Subject: [PATCH] net/thunderx: fix Tx desc corruption in scatter-gather > mode >=20 > From: Subrahmanyam Nilla >=20 > For performance reasons, word1 of send_hdr_s > sub descriptor was not cleared assuming it is always > having default value of zero since it comes from fixed > offsets of SQ buffer. > This is causing issues in case of SG mode because, > the size of send command might change and hence the word1 > of send_hdr_s is not always at fixed offsets of the SQ buffer > and hence not having default value of zero. >=20 > This fixes the issue by clearing the word1 in case of SG mode > for every packet. >=20 > Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx") > Cc: stable@dpdk.org >=20 > Signed-off-by: Subrahmanyam Nilla > Signed-off-by: Nithin Dabilpuram > --- Acked-by: Jerin Jacob