From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v2 1/1] hash: separate lf and rw lock lookup
	code paths
Date: Sun, 11 Nov 2018 07:48:22 +0000
Message-ID: <20181111074805.GA3496@jerin>
References: <20181109163917.16845-1-honnappa.nagarahalli@arm.com>
 <20181110185534.5444-1-honnappa.nagarahalli@arm.com>
 <20181110185534.5444-2-honnappa.nagarahalli@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "hemant.agrawal@nxp.com"
 <hemant.agrawal@nxp.com>, "chaozhu@linux.vnet.ibm.com"
 <chaozhu@linux.vnet.ibm.com>, "yipeng1.wang@intel.com"
 <yipeng1.wang@intel.com>, "dharmik.thakkar@arm.com"
 <dharmik.thakkar@arm.com>, "gavin.hu@arm.com" <gavin.hu@arm.com>,
 "nd@arm.com" <nd@arm.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
 "Kapoor, Prasun" <Prasun.Kapoor@cavium.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-eopbgr810044.outbound.protection.outlook.com [40.107.81.44])
 by dpdk.org (Postfix) with ESMTP id 4C3FD239
 for <dev@dpdk.org>; Sun, 11 Nov 2018 08:48:25 +0100 (CET)
In-Reply-To: <20181110185534.5444-2-honnappa.nagarahalli@arm.com>
Content-Language: en-US
Content-ID: <4561133BD8EC2742900EF5AEC265D030@namprd07.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Sat, 10 Nov 2018 12:55:34 -0600
> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> To: bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com
> CC: dev@dpdk.org, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
>  chaozhu@linux.vnet.ibm.com, yipeng1.wang@intel.com,
>  dharmik.thakkar@arm.com, gavin.hu@arm.com, honnappa.nagarahalli@arm.com,
>  nd@arm.com
> Subject: [PATCH v2 1/1] hash: separate lf and rw lock lookup code paths
> X-Mailer: git-send-email 2.17.1
>=20
>=20
> The lock-free algorithm has caused significant lookup
> performance regression for certain use cases. The
> regression is attributed to the use of non-relaxed
> memory orderings. 2 versions of the lookup functions
> are created. One that uses the RW lock and the one that
> is lock-free. This restores the performance regression
> caused for use cases that used RW lock version of the
> lookup function.
>=20
> Fixes: e605a1d36 ("hash: add lock-free r/w concurrency")
> Cc: honnappa.nagarahalli@arm.com
>=20
> Suggested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

- Reported l3fwd hash regression for ARMv8 platform fixed
  with this patch by introducing two different code path(obviously!!)
- Verified lock version of lookup() is same as e605a1d36~1 changeset

+ Thomas,

If there is no objection, please consider this patch into -RC3