From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jasvinder Singh Subject: [PATCH] testpmd: fix memory leak for dscp table Date: Wed, 14 Nov 2018 11:58:59 +0000 Message-ID: <20181114115859.160722-1-jasvinder.singh@intel.com> Cc: stable@dpdk.org, bernard.iremonger@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com To: dev@dpdk.org Return-path: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix memory leak for dscp table reported by coverity Coverity ID: 326961 Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") CC: stable@dpdk.org Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline_mtr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index 846de88db..c506d87ee 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -1148,15 +1148,15 @@ static void cmd_set_port_meter_dscp_table_parsed(void *parsed_result, } if (port_id_is_invalid(port_id, ENABLED_WARN)) - return; + goto free_table; /* Update Meter DSCP Table*/ ret = rte_mtr_meter_dscp_table_update(port_id, mtr_id, dscp_table, &error); - if (ret != 0) { + if (ret != 0) print_err_msg(&error); - return; - } + +free_table: free(dscp_table); } -- 2.17.1