From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Duszynski Subject: Re: [PATCH] net/mvpp2: fix possible uninitialized variable access Date: Thu, 15 Nov 2018 15:38:00 +0100 Message-ID: <20181115143800.GA10746@sh> References: <20181105152522.66712-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Tomasz Duszynski , Dmitri Epshtein , Natalie Samsonov , dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 57ED04CB5 for ; Thu, 15 Nov 2018 15:38:02 +0100 (CET) Received: by mail-ed1-f66.google.com with SMTP id f23so7671769edb.3 for ; Thu, 15 Nov 2018 06:38:02 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181105152522.66712-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 05, 2018 at 03:25:22PM +0000, Ferruh Yigit wrote: > Fixes: cdb53f8da628 ("net/mvpp2: support metering") > > Signed-off-by: Ferruh Yigit > --- > drivers/net/mvpp2/mrvl_mtr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mvpp2/mrvl_mtr.c b/drivers/net/mvpp2/mrvl_mtr.c > index 9cd53bed5..9adcd9751 100644 > --- a/drivers/net/mvpp2/mrvl_mtr.c > +++ b/drivers/net/mvpp2/mrvl_mtr.c > @@ -422,7 +422,7 @@ mrvl_meter_profile_update(struct rte_eth_dev *dev, ui= nt32_t mtr_id, > struct mrvl_priv *priv =3D dev->data->dev_private; > struct mrvl_mtr_profile *profile; > struct mrvl_mtr *mtr; > - int ret, enabled; > + int ret, enabled =3D 0; > > if (!priv->ppio) > return -rte_mtr_error_set(error, EPERM, > -- > 2.17.2 > Looks good. Acked-by: Tomasz Duszynski -- - Tomasz Duszy=C5=84ski