From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit Date: Mon, 19 Nov 2018 09:10:42 -0800 Message-ID: <20181119091042.1977b022@xeon-e3> References: <9f22d89841c440c32235117e1a4fe223f97c7f8e.1542616118.git.leah@ethernitynet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Ouyang Changchun To: Leah Tekoa Return-path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 0061B2C52 for ; Mon, 19 Nov 2018 18:10:50 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id n2so6930827pgm.3 for ; Mon, 19 Nov 2018 09:10:50 -0800 (PST) In-Reply-To: <9f22d89841c440c32235117e1a4fe223f97c7f8e.1542616118.git.leah@ethernitynet.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 19 Nov 2018 08:38:44 +0000 Leah Tekoa wrote: > - link = dev->data->dev_link; > + memcpy(&link, &dev->data->dev_link, sizeof(struct rte_eth_link)); > If structure assignment and memcpy don't give same result, then you have a buggy compiler.