From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] compressdev: add feature flag to specify where processing is done Date: Tue, 20 Nov 2018 10:07:03 -0800 Message-ID: <20181120100703.34c462e9@xeon-e3> References: <1542677988-3876-1-git-send-email-fiona.trahe@intel.com> <20181119175349.2bd2fdd1@xeon-e3> <348A99DA5F5B7549AA880327E580B4358967C84F@IRSMSX101.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Jozwiak, TomaszX" , "shally.verma@caviumnetworks.com" , "ashish.gupta@caviumnetworks.com" , "Daly, Lee" To: "Trahe, Fiona" Return-path: Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 32EAD11A4 for ; Tue, 20 Nov 2018 19:07:13 +0100 (CET) Received: by mail-pl1-f194.google.com with SMTP id s5-v6so1455507plq.11 for ; Tue, 20 Nov 2018 10:07:13 -0800 (PST) In-Reply-To: <348A99DA5F5B7549AA880327E580B4358967C84F@IRSMSX101.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 20 Nov 2018 16:25:25 +0000 "Trahe, Fiona" wrote: > Hi Stephen, > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Monday, November 19, 2018 6:54 PM > > To: Trahe, Fiona > > Cc: dev@dpdk.org; akhil.goyal@nxp.com; Jozwiak, TomaszX ; > > shally.verma@caviumnetworks.com; ashish.gupta@caviumnetworks.com; Daly, Lee > > Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done > > > > On Tue, 20 Nov 2018 01:39:48 +0000 > > Fiona Trahe wrote: > > > > > A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE > > > is added. A PMD which processes operations using a software > > > acceleration engine should set this if the bulk of the > > > processing is done during the dequeue. It should leave it > > > cleared if the bulk of the processing is done during the > > > enqueue (default). > > > An application may find this useful for tuning. > > > > > > Signed-off-by: Fiona Trahe > > > > What application? or is this "if we build it they will come?" > [Fiona] Our storage team asked for this, so not quite. > Seems like it might by generically useful, so a bit of the latter too :) > Would you prefer I removed that line? Hopefully, there would be one or more open source projects using the API. I just did a survey of DPDK an 1/3 of it is never used by any open source project. Hate to see more dead code and special cases created. At least, some example code in examples would help. Something like a simple in memory compressed storage server using a network API (SMB?/SSH?/FTP?)