From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v2] config: enable more than 128 cores for
	Arm64 platform
Date: Wed, 21 Nov 2018 11:34:42 +0000
Message-ID: <20181121113422.GA31379@jerin>
References: <1542798625-46722-1-git-send-email-joyce.kong@arm.com>
 <1542799632-47517-1-git-send-email-joyce.kong@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net"
 <thomas@monjalon.net>, "Honnappa.Nagarahalli@arm.com"
 <Honnappa.Nagarahalli@arm.com>, "gavin.hu@arm.com" <gavin.hu@arm.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: Joyce Kong <joyce.kong@arm.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1542799632-47517-1-git-send-email-joyce.kong@arm.com>
Content-Language: en-US
Content-ID: <A1D0F982E27AED4B9ECDDDFCD6185587@namprd07.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Wed, 21 Nov 2018 19:27:12 +0800
> From: Joyce Kong <joyce.kong@arm.com>
> To: dev@dpdk.org
> CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
>  Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, stable@dpdk.org
> Subject: [PATCH v2] config: enable more than 128 cores for Arm64 platform
> X-Mailer: git-send-email 2.7.4
>=20
>=20
> When running dpdk applications on cores whose ids are bigger
> than original max_core setting, eal error as below:
> EAL: Detected 104 lcore(s)
> EAL: Detected 2 NUMA nodes
> EAL: invalid core list
> -l CORELIST core indexes between 0 and 128
>=20
> The fix is to increase max_core to 256 on Arm64 platform.
>=20
> Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
>  config/arm/meson.build                     | 2 +-
>  config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index b755138..020df09 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -51,7 +51,7 @@ flags_cavium =3D [
>         ['RTE_MACHINE', '"thunderx"'],
>         ['RTE_CACHE_LINE_SIZE', 128],
>         ['RTE_MAX_NUMA_NODES', 2],
> -       ['RTE_MAX_LCORE', 96],
> +       ['RTE_MAX_LCORE', 256],

This change makes thunderx config to 256 cores not armv8.=20
For generic config, it needs to be under "flags_generic"
not under "flags_cavium". Just like you did for updating
defconfig_arm64-armv8a-linuxapp-gcc config instead of
defconfig_arm64-thunderx-linuxapp-gcc

>         ['RTE_MAX_VFIO_GROUPS', 128],
>         ['RTE_USE_C11_MEM_MODEL', false]]
>  flags_dpaa =3D [
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfi=
g_arm64-armv8a-linuxapp-gcc
> index 1842744..a6ed90c 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -6,3 +6,4 @@
>=20
>  CONFIG_RTE_TOOLCHAIN=3D"gcc"
>  CONFIG_RTE_TOOLCHAIN_GCC=3Dy
> +CONFIG_RTE_MAX_LCORE=3D256
> --
> 2.7.4
>=20