From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] helloworld: Windows DPDK sample application
 is compiled and built using eal and kvargs libraries in order to add
 windows support in the mainline repository.
Date: Thu, 29 Nov 2018 10:15:06 -0800
Message-ID: <20181129101506.32c9de3c@xeon-e3>
References: <20181129050504.26996-1-pallavi.kadam@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Pallavi Kadam <pallavi.kadam@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com
 [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id 39F6A262E
 for <dev@dpdk.org>; Thu, 29 Nov 2018 19:15:16 +0100 (CET)
Received: by mail-pf1-f169.google.com with SMTP id u6so1406260pfh.11
 for <dev@dpdk.org>; Thu, 29 Nov 2018 10:15:15 -0800 (PST)
In-Reply-To: <20181129050504.26996-1-pallavi.kadam@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 28 Nov 2018 21:05:04 -0800
Pallavi Kadam <pallavi.kadam@intel.com> wrote:

> +// If we define WIN32_LEAN_AND_MEAN, winsock isn't included by default. We can then include it in specific header files as we need later.
> +#define WIN32_LEAN_AND_MEAN

All this is Windows code, it would be best if the code style of the new code
matches the rest of the DPDK. The DPDK follows subset of Linux kernel style
standard. In that standard C++ style comments are not used.