From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] kni: use kni_ethtool_ops only with
 unknown drivers
Date: Fri, 30 Nov 2018 15:38:15 -0800
Message-ID: <20181130153815.3be2f30b@xeon-e3>
References: <20181130192946.13732-1-iryzhov@nfware.com>
 <20181130194750.13870-1-iryzhov@nfware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Igor Ryzhov <iryzhov@nfware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com
 [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id B59111B5CA
 for <dev@dpdk.org>; Sat,  1 Dec 2018 00:38:18 +0100 (CET)
Received: by mail-pg1-f193.google.com with SMTP id n2so3152995pgm.3
 for <dev@dpdk.org>; Fri, 30 Nov 2018 15:38:18 -0800 (PST)
In-Reply-To: <20181130194750.13870-1-iryzhov@nfware.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 30 Nov 2018 22:47:50 +0300
Igor Ryzhov <iryzhov@nfware.com> wrote:

> Current implementation of kni_ethtool_ops just uses corresponding
> ethtool_ops function of underlying driver for all functions except for
> .get_link. This commit sets kni->net_dev->ethtool_ops directly to the
> ethtool_ops of the corresponding driver.
> 
> For unknown drivers (all but ixgbe and i40e) we still use
> kni_ethtool_ops with implemented .get_link function.
> 
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

Why does KNI still support ethtool which:
  1. Only works on a subset of devices
  2. Requires a 3rd implmentation of the HW device (Linux, DPDK, and KNI)

Then again why does KNI exist at all? What is missing from virtio user which
is faster anyway.