From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH 1/1] app/eventdev: detect deadlock for timer event producer Date: Sat, 1 Dec 2018 15:12:03 +0000 Message-ID: <20181201151150.GC26004@jerin> References: <1543519131-18910-1-git-send-email-erik.g.carrillo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Bhagavatula, Pavan" , "dev@dpdk.org" To: Erik Gabriel Carrillo Return-path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730075.outbound.protection.outlook.com [40.107.73.75]) by dpdk.org (Postfix) with ESMTP id B7CFE1B213 for ; Sat, 1 Dec 2018 16:12:05 +0100 (CET) In-Reply-To: <1543519131-18910-1-git-send-email-erik.g.carrillo@intel.com> Content-Language: en-US Content-ID: <94D9D5404ADB0841A47085F2B19A5417@namprd07.prod.outlook.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Thu, 29 Nov 2018 13:18:51 -0600 > From: Erik Gabriel Carrillo > To: pbhagavatula@caviumnetworks.com > CC: jerin.jacob@caviumnetworks.com, dev@dpdk.org > Subject: [PATCH 1/1] app/eventdev: detect deadlock for timer event produc= er > X-Mailer: git-send-email 1.7.10 >=20 > If timer events get dropped for some reason, the thread that launched > producer and worker cores will never exit, because the deadlock check > doesn't currently apply to the event timer adapter case. This commit > fixes this. Please add Fixes: With above changes, Acked-by: Jerin Jacob >=20 > Signed-off-by: Erik Gabriel Carrillo > --- > app/test-eventdev/test_perf_common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/tes= t_perf_common.c > index 8618775..f99a6a6 100644 > --- a/app/test-eventdev/test_perf_common.c > +++ b/app/test-eventdev/test_perf_common.c > @@ -327,7 +327,8 @@ perf_launch_lcores(struct evt_test *test, struct evt_= options *opt, > } >=20 > if (new_cycles - dead_lock_cycles > dead_lock_sample && > - opt->prod_type =3D=3D EVT_PROD_TYPE_SYNT)= { > + (opt->prod_type =3D=3D EVT_PROD_TYPE_SYNT || > + opt->prod_type =3D=3D EVT_PROD_TYPE_EVENT_TIMER_ADPT= R)) { > remaining =3D t->outstand_pkts - processed_pkts(t= ); > if (dead_lock_remaining =3D=3D remaining) { > rte_event_dev_dump(opt->dev_id, stdout); > -- > 2.6.4 >=20