From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Maximets Subject: [PATCH] net/virtio: move bytes accounting to common function Date: Mon, 3 Dec 2018 19:20:13 +0300 Message-ID: <20181203162013.17310-1-i.maximets@samsung.com> References: Content-Type: text/plain; charset="utf-8" Cc: Maxime Coquelin , Tiwei Bie , Zhihong Wang , Ilya Maximets To: dev@dpdk.org Return-path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 990AB235 for ; Mon, 3 Dec 2018 17:20:23 +0100 (CET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181203162022euoutp02f86bd1efafe07c5fbb089bc8b2406308~s3w22IAep0141401414euoutp02k for ; Mon, 3 Dec 2018 16:20:22 +0000 (GMT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is no need to count 'bytes' separately. Signed-off-by: Ilya Maximets --- drivers/net/virtio/virtio_rxtx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index eb891433e..cb8f89f18 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -775,6 +775,8 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) uint32_t s = mbuf->pkt_len; struct ether_addr *ea; + stats->bytes += s; + if (s == 64) { stats->size_bins[1]++; } else if (s > 64 && s < 1024) { @@ -806,7 +808,6 @@ virtio_rx_stats_updated(struct virtnet_rx *rxvq, struct rte_mbuf *m) { VIRTIO_DUMP_PACKET(m, m->data_len); - rxvq->stats.bytes += m->pkt_len; virtio_update_packet_stats(&rxvq->stats, m); } @@ -1310,7 +1311,6 @@ virtio_recv_mergeable_pkts(void *rx_queue, VIRTIO_DUMP_PACKET(rx_pkts[nb_rx], rx_pkts[nb_rx]->data_len); - rxvq->stats.bytes += rx_pkts[nb_rx]->pkt_len; virtio_update_packet_stats(&rxvq->stats, rx_pkts[nb_rx]); nb_rx++; } @@ -1423,7 +1423,6 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) virtqueue_enqueue_xmit(txvq, txm, slots, use_indirect, can_push, 0); - txvq->stats.bytes += txm->pkt_len; virtio_update_packet_stats(&txvq->stats, txm); } @@ -1498,7 +1497,6 @@ virtio_xmit_pkts_inorder(void *tx_queue, inorder_pkts[nb_inorder_pkts] = txm; nb_inorder_pkts++; - txvq->stats.bytes += txm->pkt_len; virtio_update_packet_stats(&txvq->stats, txm); continue; } @@ -1529,7 +1527,6 @@ virtio_xmit_pkts_inorder(void *tx_queue, /* Enqueue Packet buffers */ virtqueue_enqueue_xmit(txvq, txm, slots, 0, 0, 1); - txvq->stats.bytes += txm->pkt_len; virtio_update_packet_stats(&txvq->stats, txm); } -- 2.17.1