From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH 6/9] net/ifc: add devarg for LM mode
Date: Tue, 4 Dec 2018 14:31:51 +0800
Message-ID: <20181204063150.GA20433@btwcube1>
References: <20181128094607.106173-1-xiao.w.wang@intel.com>
 <20181128094607.106173-7-xiao.w.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: maxime.coquelin@redhat.com, dev@dpdk.org, zhihong.wang@intel.com,
 xiaolong.ye@intel.com
To: Xiao Wang <xiao.w.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id B1EF21B3A9
 for <dev@dpdk.org>; Tue,  4 Dec 2018 07:33:45 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20181128094607.106173-7-xiao.w.wang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Nov 28, 2018 at 05:46:04PM +0800, Xiao Wang wrote:
[...]
> @@ -767,6 +771,7 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
>  	struct ifcvf_internal *internal = NULL;
>  	struct internal_list *list = NULL;
>  	int vdpa_mode = 0;
> +	int sw_fallback_lm = 0;
>  	struct rte_kvargs *kvlist = NULL;
>  	int ret = 0;
>  
> @@ -826,6 +831,16 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
>  	internal->dev_addr.type = PCI_ADDR;
>  	list->internal = internal;
>  
> +	if (rte_kvargs_count(kvlist, IFCVF_SW_FALLBACK_LM)) {
> +		ret = rte_kvargs_process(kvlist, IFCVF_SW_FALLBACK_LM,
> +				&open_int, &sw_fallback_lm);
> +		if (ret < 0)
> +			goto error;
> +		internal->sw_lm = sw_fallback_lm ? true : false;
> +	} else {
> +		internal->sw_lm = false;
> +	}

Something like this would be better:

	if (rte_kvargs_count(kvlist, IFCVF_SW_FALLBACK_LM)) {
		ret = rte_kvargs_process(kvlist, IFCVF_SW_FALLBACK_LM,
				&open_int, &sw_fallback_lm);
		if (ret < 0)
			goto error;
	}

	internal->sw_lm = sw_fallback_lm;


>  	internal->did = rte_vdpa_register_device(&internal->dev_addr,
>  				&ifcvf_ops);
>  	if (internal->did < 0) {
> -- 
> 2.15.1
>