From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: support double precision RED queue
 weight
Date: Mon, 10 Dec 2018 07:57:11 -0800
Message-ID: <20181210075711.1befe533@xeon-e3>
References: <1543470882-145287-1-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: cristian.dumitrescu@intel.com, jasvinder.singh@intel.com, dev@dpdk.org
To: Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com
 [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 4F07F1B113
 for <dev@dpdk.org>; Mon, 10 Dec 2018 16:57:14 +0100 (CET)
Received: by mail-pl1-f195.google.com with SMTP id u18so5430679plq.7
 for <dev@dpdk.org>; Mon, 10 Dec 2018 07:57:14 -0800 (PST)
In-Reply-To: <1543470882-145287-1-git-send-email-nikhil.rao@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 29 Nov 2018 11:24:42 +0530
Nikhil Rao <nikhil.rao@intel.com> wrote:

>  
> +	/** Double precision RED queue weight support. When non-zero, this
> +	 * this parameter indicates that RED queue weight in double precision
> +	 * format is supported.
> +	 * @see struct rte_tm_red_params::wq_is_log2
> +	 * @see struct rte_tm_red_params::wq_dp
> +	 */
> +	int cman_wred_wq_dp_supported;
> +
> +	/** Negated log2 RED queue weight support. When non-zero, this
> +	 * parameter indicates that RED queue weight in negated log2 format
> +	 * is supported.
> +	 * @see struct rte_tm_red_params::wq_is_log2
> +	 * @see struct rte_tm_red_params::wq_log2
> +	 */
> +	int cman_wred_wq_log2_supported;
> +

One suggestion:
Since these are flag values use u8. Takes less space.
And maybe use pahole utility to find existing hole to put
them in.