From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: support double precision RED queue
 weight
Date: Mon, 10 Dec 2018 08:01:09 -0800
Message-ID: <20181210080109.617902f1@xeon-e3>
References: <1543470882-145287-1-git-send-email-nikhil.rao@intel.com>
 <20181128221245.017eadcf@xeon-e3>
 <1F668163772FA946975B9466A9DFF729ED3AF9EF@ORSMSX110.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "Singh,
 Jasvinder" <jasvinder.singh@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com
 [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 53BD75F2D
 for <dev@dpdk.org>; Mon, 10 Dec 2018 17:01:12 +0100 (CET)
Received: by mail-pf1-f196.google.com with SMTP id c123so5615298pfb.0
 for <dev@dpdk.org>; Mon, 10 Dec 2018 08:01:12 -0800 (PST)
In-Reply-To: <1F668163772FA946975B9466A9DFF729ED3AF9EF@ORSMSX110.amr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 10 Dec 2018 05:43:37 +0000
"Rao, Nikhil" <nikhil.rao@intel.com> wrote:

> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Thursday, November 29, 2018 11:43 AM
> > To: Rao, Nikhil <nikhil.rao@intel.com>
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> > <jasvinder.singh@intel.com>; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue
> > weight
> > 
> > On Thu, 29 Nov 2018 11:24:42 +0530
> > Nikhil Rao <nikhil.rao@intel.com> wrote:
> >   
> > > RED queue weight is currently specified as a negated log of 2.
> > >
> > > Add support for RED queue weight to be specified in double precision
> > > and TM capability flags for double precision and negated log2 RED
> > > queue weight support.
> > >
> > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>  
> > 
> > Since this is an ABI break anyway, why not just commit to the new format?  
> 
> Hi Stephen,
> 
> Can you please provide more detail on your comment ?  are you suggesting replacing the wq_log2/wq_dp with a double ?
> 
> Thanks,
> Nikhil


My comment is that since you are changing a structure layout, which would
break existing users; why not go farther and just fix the API to a better
version. I don't think any projects use this code anyway,
see my talk (https://github.com/shemminger/dpdk-metrics).

Isn't floating point going to be expensive. Or is it only during the setup
process, not enqueue/dequeue.