From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harman Kalra Subject: [PATCH] raw/skeleton: fix segmentation fault on rawdev_autotest Date: Tue, 11 Dec 2018 13:14:30 +0000 Message-ID: <20181211131412.14232-1-hkalra@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "marko.kallio@cavium.com" , Harman Kalra , Kallio Marko To: "shreyansh.jain@nxp.com" , "hemant.agrawal@nxp.com" Return-path: Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 868B54CAB for ; Tue, 11 Dec 2018 14:14:34 +0100 (CET) Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" segmentation fault ocured as vdev->device.driver->name did not return correct value. Test2 failed as dummy_value was freed before it was used. Signed-off-by: Kallio Marko Signed-off-by: Harman Kalra --- drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 3 ++- drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c b/drivers/raw/sk= eleton_rawdev/skeleton_rawdev.c index d7630fc69..c957ced11 100644 --- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c +++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c @@ -585,7 +585,8 @@ skeleton_rawdev_create(const char *name, =20 rawdev->dev_ops =3D &skeleton_rawdev_ops; rawdev->device =3D &vdev->device; - rawdev->driver_name =3D vdev->device.driver->name; + + rawdev->driver_name =3D rawdev->name; =20 skeldev =3D skeleton_rawdev_get_priv(rawdev); =20 diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c b/drivers/r= aw/skeleton_rawdev/skeleton_rawdev_test.c index 359c9e296..788c3f1b9 100644 --- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c @@ -294,14 +294,14 @@ test_rawdev_attr_set_get(void) "Attribute (Test1) not set correctly (%" PRIu64 ")", ret_value); =20 - free(dummy_value); - ret_value =3D 0; ret =3D rte_rawdev_get_attr(TEST_DEV_ID, "Test2", &ret_value); RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), 200, "Attribute (Test2) not set correctly (%" PRIu64 ")", ret_value); =20 + free(dummy_value); + return TEST_SUCCESS; } =20 --=20 2.18.0