From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] eal: simplify RTE_PMD_DEBUG_TRACE
Date: Fri, 14 Dec 2018 13:57:59 -0800
Message-ID: <20181214135759.02f97f36@xeon-e3>
References: <20181214163827.9403-1-jeffrey.b.shaw@intel.com>
 <dc4f658d-76a4-ff6f-d3c0-21084e439d27@lysator.liu.se>
 <20181214190713.GB9964@ae13-28.jf.intel.com>
 <3a573b56-6ea0-812c-4641-830fbd3c59cc@ericsson.com>
 <20181214125055.1153c38c@xeon-e3>
 <20181214212007.GA6612@ae13-28.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Mattias =?UTF-8?B?UsO2bm5ibG9t?= <mattias.ronnblom@ericsson.com>,
 dev@dpdk.org
To: Jeff Shaw <jeffrey.b.shaw@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com
 [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 2B7761B9B8
 for <dev@dpdk.org>; Fri, 14 Dec 2018 22:58:03 +0100 (CET)
Received: by mail-pf1-f196.google.com with SMTP id w73so3428870pfk.10
 for <dev@dpdk.org>; Fri, 14 Dec 2018 13:58:02 -0800 (PST)
In-Reply-To: <20181214212007.GA6612@ae13-28.jf.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 14 Dec 2018 13:20:07 -0800
Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:

> On Fri, Dec 14, 2018 at 12:50:55PM -0800, Stephen Hemminger wrote:
> > Use rte_log directly, eliminating no longer used rte_pmd_dev_trace
> > function. This removes variable length array which is problem on
> > Windows and other compilers not doing C99.
> > 
> > Also, drop unused RTE_PROC_PRIMARY macros.
> > 
> > Reported-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  lib/librte_eal/common/include/rte_dev.h | 43 ++-----------------------
> >  1 file changed, 3 insertions(+), 40 deletions(-)
> > 
> > diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
> > index a9724dc9181c..e496da440028 100644
> > --- a/lib/librte_eal/common/include/rte_dev.h
> > +++ b/lib/librte_eal/common/include/rte_dev.h
> > @@ -43,54 +43,17 @@ typedef void (*rte_dev_event_cb_fn)(const char *device_name,
> >  					enum rte_dev_event_type event,
> >  					void *cb_arg);
> >  
> > -__attribute__((format(printf, 2, 0)))
> > -static inline void
> > -rte_pmd_debug_trace(const char *func_name, const char *fmt, ...)
> > -{
> > -	va_list ap;
> > -
> > -	va_start(ap, fmt);
> > -
> > -	{
> > -		char buffer[vsnprintf(NULL, 0, fmt, ap) + 1];
> > -
> > -		va_end(ap);
> > -
> > -		va_start(ap, fmt);
> > -		vsnprintf(buffer, sizeof(buffer), fmt, ap);
> > -		va_end(ap);
> > -
> > -		rte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, "%s: %s",
> > -			func_name, buffer);
> > -	}
> > -}
> > -  
> 
> Will this break applications that try to use this function? Because it is not
> a documented function, is there no guarantee it will be present?

It shouldn't be visible as part of EAL. Any code that was built that had
old MACRO would still run (ABI compatible) because it was inline.