From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rahul Lakkireddy Subject: Re: [PATCH v2 0/4] net/cxgbe: fix build for Microsoft Windows OS support Date: Thu, 20 Dec 2018 09:24:07 +0530 Message-ID: <20181220035406.GA13374@chelsio.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" , Satish Rangarajan , Indranil Choudhury To: Ferruh Yigit Return-path: Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by dpdk.org (Postfix) with ESMTP id DA7351B936 for ; Thu, 20 Dec 2018 04:55:50 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thursday, December 12/20/18, 2018 at 03:09:44 +0530, Ferruh Yigit wrote: > On 12/19/2018 4:28 PM, Rahul Lakkireddy wrote: > > This series of patches fix compilation warning and errors seen while > > building CXGBE PMD in preparation for Microsoft Windows OS support. > > > > Patch 1 uses relative paths for including header files. > > Patch 2 fixes macros related to rte_log(). > > Patch 3 only redefines symbols when they are not available. > > Patch 4 fixes other misc build issues. > > > > Patches are generated against dpdk-next-net tree. > > > > Build Environment: > > 1. Target OS: Microsoft Windows Server 2016 > > 2. Compiler: Intel C++ Compiler v19 from Intel Parallel Studio XE 2019 [1] > > 3. Development Tools: > > 3.1 Microsoft Visual Studio 2017 Professional > > 3.2 Windows Software Development Kit (SDK) v10.0.17763 > > 3.3 Windows Driver Kit (WDK) v10.0.17763 > > > > [1] https://software.intel.com/en-us/parallel-studio-xe > > > > Thanks, > > Rahul > > > > --- > > v2: > > - Add more info in commit message regarding Windows build. > > > > Rahul Lakkireddy (4): > > net/cxgbe: use relative paths for including header files > > net/cxgbe: fix macros related to logs for Windows > > net/cxgbe: only define symbols when not available > > net/cxgbe: fix other misc build issues for Windows > > Series applied to dpdk-next-net/master, thanks. > > Beware none of the patches has fixes lines, so they won't be backported by default. > If this wasn't the intention please provide fixes lines and I can update in tree. Thanks Ferruh. I intentionally left out the fixes lines. Don't backport these patches. Thanks, Rahul