From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] hash: fix out-of-bound write while freeing key slot Date: Thu, 20 Dec 2018 13:59:17 +0000 Message-ID: <20181220135917.GA13596@bricha3-MOBL.ger.corp.intel.com> References: <20181122025156.42217-1-honnappa.nagarahalli@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org, yipeng1.wang@intel.com, gavin.hu@arm.com, nd@arm.com To: Honnappa Nagarahalli Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 360D91BC6E for ; Thu, 20 Dec 2018 14:59:22 +0100 (CET) Content-Disposition: inline In-Reply-To: <20181122025156.42217-1-honnappa.nagarahalli@arm.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 21, 2018 at 08:51:56PM -0600, Honnappa Nagarahalli wrote: > Add a debug check for out-of-bound write while freeing the key slot. > > Coverity issue: 325733 > Fixes: e605a1d36ca7 ("hash: add lock-free r/w concurrency") > Cc: honnappa.nagarahalli@arm.com > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Steve Capper > Reviewed-by: Gavin Hu > --- > lib/librte_hash/rte_cuckoo_hash.c | 4 ++++ > lib/librte_hash/rte_cuckoo_hash.h | 11 +++++++++++ > 2 files changed, 15 insertions(+) > While I think enqueuing a free slot should ever fail, I don't see an issue with having a check for that. Acked-by: Bruce Richardson