From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM
 meter support
Date: Fri, 4 Jan 2019 11:42:35 -0800
Message-ID: <20190104114235.228a31f9@hermes.lan>
References: <154661036216.75321.4852909033090962683.stgit@dbuild>
 <154661038141.75321.10886021990395716851.stgit@dbuild>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: cristian.dumitrescu@intel.com, dev@dpdk.org
To: Eelco Chaudron <echaudro@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com
 [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id D3C0B1B4BA
 for <dev@dpdk.org>; Fri,  4 Jan 2019 20:42:42 +0100 (CET)
Received: by mail-pf1-f196.google.com with SMTP id i12so18745909pfo.7
 for <dev@dpdk.org>; Fri, 04 Jan 2019 11:42:42 -0800 (PST)
In-Reply-To: <154661038141.75321.10886021990395716851.stgit@dbuild>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri,  4 Jan 2019 13:59:42 +0000
Eelco Chaudron <echaudro@redhat.com> wrote:

> This patch adds support for RFC4115 trTCM meters.
> 
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>



Fix comment formatting.

### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#172: FILE: lib/librte_meter/rte_meter.h:59:
+/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and EBS
+parameters only count bytes of IP packets and do not include link specific

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#174: FILE: lib/librte_meter/rte_meter.h:61:
+none-zero respectively.*/

WARNING:LONG_LINE_COMMENT: line over 80 characters
#176: FILE: lib/librte_meter/rte_meter.h:63:
+	uint64_t cir; /**< Committed Information Rate (CIR). Measured in bytes per second. */

WARNING:LONG_LINE_COMMENT: line over 80 characters
#177: FILE: lib/librte_meter/rte_meter.h:64:
+	uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes per second. */

WARNING:LONG_LINE_COMMENT: line over 80 characters
#355: FILE: lib/librte_meter/rte_meter.h:406:
+	/**< Number of bytes currently available in the excess(E) token bucket */

total: 0 errors, 5 warnings, 356 lines checked