From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hunt Subject: [PATCH] lib/power: fix return code to unsigned value Date: Mon, 7 Jan 2019 14:40:23 +0000 Message-ID: <20190107144023.7041-1-david.hunt@intel.com> Cc: david.hunt@intel.com, liang.j.ma@intel.com To: dev@dpdk.org Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0252D1B3FB for ; Mon, 7 Jan 2019 15:40:28 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The power_pstate_cpufreq_freqs() function was returning -1 in an unsigned int, causing buffer over-runs when the results were being processed. This function should be returning zero for all error conditions, similar to it's acpi relation, power_acpi_cpufreq_freqs(). Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") Signed-off-by: David Hunt --- lib/librte_power/power_pstate_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c index 0a566eb07..9ec5da511 100644 --- a/lib/librte_power/power_pstate_cpufreq.c +++ b/lib/librte_power/power_pstate_cpufreq.c @@ -577,7 +577,7 @@ power_pstate_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num) if (lcore_id >= RTE_MAX_LCORE) { RTE_LOG(ERR, POWER, "Invalid lcore ID\n"); - return -1; + return 0; } if (freqs == NULL) { -- 2.17.1