From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: net/bonding: fix possible null pointer reference Date: Tue, 8 Jan 2019 11:17:56 +0000 Message-ID: <20190108111756.9118-1-declan.doherty@intel.com> Cc: stable@dpdk.org, Chas Williams , Declan Doherty To: dev@dpdk.org Return-path: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In function check_for_bonded_ethdev the driver name is used without validating the pointer references in the passed ethdev object. Fixes: 740feaf349b1 ("ethdev: remove driver name from device private data") Cc: stable@dpdk.org Signed-off-by: Declan Doherty --- drivers/net/bonding/rte_eth_bond_api.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index 21bcd5044..e5e146540 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -19,7 +19,10 @@ int check_for_bonded_ethdev(const struct rte_eth_dev *eth_dev) { /* Check valid pointer */ - if (eth_dev->device->driver->name == NULL) + if (eth_dev == NULL || + eth_dev->device == NULL || + eth_dev->device->driver == NULL || + eth_dev->device->driver->name == NULL) return -1; /* return 0 if driver name matches */ -- 2.14.5