From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] eal: move compat includes to common meson file Date: Wed, 9 Jan 2019 20:51:59 +0000 Message-ID: <20190109205159.GA12480@bricha3-MOBL.ger.corp.intel.com> References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anatoly Burakov , dev@dpdk.org, Thomas Monjalon , stable@dpdk.org To: David Marchand Return-path: Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: > On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov > <[1]anatoly.burakov@intel.com> wrote: > > Currently, while EAL does depend on librte_compat as far as common > meson build is concerned, for some reason the headers for that > library are not added into the list of includes. This is fixed in > Linuxapp-specific meson file, but is absent from FreeBSD meson file. > This worked fine up until recently, when an rte_compat dependency > was added to rte_log, which is a common header. Fix this issue by > adding librte_compat includes to common EAL meson file. > Fixes: 844514c73569 ("eal: build with meson") > Fixes: a8499f65a1d1 ("log: add missing experimental tag") > Cc: [2]bruce.richardson@intel.com > Cc: [3]david.marchand@redhat.com > Cc: [4]stable@dpdk.org > Signed-off-by: Anatoly Burakov <[5]anatoly.burakov@intel.com> > > lgtm, thanks. > Reviewed-by: David Marchand <[6]david.marchand@redhat.com> > -- > David Marchand > Agreed. One other point I'd make is that having compat as a separate library seems a little like overkill to me - it's just one header file! Is there a reason why we don't just move it into the EAL where everyone can use it without having to specify another dependency? /Bruce