From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] eal: move compat includes to common meson file Date: Thu, 10 Jan 2019 11:13:28 +0000 Message-ID: <20190110111328.GA7764@bricha3-MOBL.ger.corp.intel.com> References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> <1557339.2CBSiR8abE@xps> <2632071.H5f8aPozaM@xps> <20190110100220.GA13196@bricha3-MOBL.ger.corp.intel.com> <20190110104135.GA4728@bricha3-MOBL.ger.corp.intel.com> <20190110104839.GB4728@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Burakov, Anatoly" , Thomas Monjalon , dev@dpdk.org To: David Marchand Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BF1251B5F1 for ; Thu, 10 Jan 2019 12:13:32 +0100 (CET) Content-Disposition: inline In-Reply-To: <20190110104839.GB4728@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 10, 2019 at 10:48:39AM +0000, Bruce Richardson wrote: > On Thu, Jan 10, 2019 at 11:44:07AM +0100, David Marchand wrote: > > On Thu, Jan 10, 2019 at 11:41 AM Bruce Richardson > > <[1]bruce.richardson@intel.com> wrote: > > > > On Thu, Jan 10, 2019 at 10:34:19AM +0000, Burakov, Anatoly wrote: > > > On 10-Jan-19 10:02 AM, Bruce Richardson wrote: > > > > I also forgot that. However, that does bring up the thought that > > for some > > > > of our headers we may want them available for all libraries even > > before EAL > > > > is compiled up. [I think this hits on the idea Thomas was > > discussing of > > > > splitting EAL up into two, where we have a core part that is > > always > > > > compiled first and has no dependencies followed by another which > > is built > > > > later and can have dependencies.] > > > > > > > > For this specific issue, my thought is that we should indeed > > move compat.h > > > > into EAL, but also add the EAL common/include/ path to the > > global include > > > > path for the project, so all EAL headers (e.g. including those > > with defines > > > > for cacheline size, and other common macros) are just always > > available. > > > > Libs like kvargs and others should be able to use RTE_DIM etc. > > for > > > > consistency with the rest of DPDK. > > > > > > > > /Bruce > > > > > > > > > > Patches welcome so! :) > > > > > Working on it... :-) > > > > I don't think it is that quick to do, so, for the time being, do we go > > with this patch ? > > -- > > David Marchand > > > While I'm not splitting EAL up, I have got a working patch for merging > compat into EAL, and it seems to build ok for meson and ninja. I'll send it > out shortly once I finish my final cleanup and checks on it. Incidentally, > it doesn't appear that compat is used by kvargs, despite it being listed as > a dependency of it. > > /Bruce Please review/test: http://patches.dpdk.org/patch/49576/ Thanks, /Bruce