From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] compat: merge compat library into EAL
Date: Thu, 10 Jan 2019 13:19:50 +0000
Message-ID: <20190110131950.GA7312@bricha3-MOBL.ger.corp.intel.com>
References: <20190110111104.56464-1-bruce.richardson@intel.com>
 <CAJFAV8zjbxyKWpNGdd7c3w4cAwdDPPxwXa5u-Dchz_NnsJ+5-w@mail.gmail.com>
 <CAJFAV8zkA5e8GqjyZdfBpMvaT8QHSOkj4e+hHUMCsAcPoOc4Ug@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: David Marchand <david.marchand@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 077571B63D
 for <dev@dpdk.org>; Thu, 10 Jan 2019 14:19:54 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <CAJFAV8zkA5e8GqjyZdfBpMvaT8QHSOkj4e+hHUMCsAcPoOc4Ug@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 10, 2019 at 01:53:20PM +0100, David Marchand wrote:
>    On Thu, Jan 10, 2019 at 1:28 PM David Marchand
>    <[1]david.marchand@redhat.com> wrote:
> 
>    On Thu, Jan 10, 2019 at 12:12 PM Bruce Richardson
>    <[2]bruce.richardson@intel.com> wrote:
> 
>      Since compat library is only a single header, we can easily move it
>      into
>      the EAL common headers instead of tracking it separately. The
>      downside of
>      this is that it becomes a little more difficult to have any libs
>      that are
>      built before EAL depend on it. Thankfully, this is not the case, so
>      there
>      are no big complications to the move.
>      However, to ensure that we don't later hit problems later with this,
>      we can
>      add EAL common headers folder to the global include list in the
>      meson build
>      which means that all common headers can be safely used by all
>      libraries, no
>      matter what their build order.
>      Signed-off-by: Bruce Richardson <[3]bruce.richardson@intel.com>
> 
>    Currently testing this patch, I just noticed some remaining traces of
>    librte_compat:
> 
>    Checked build with make and meson on rhel7.
>    --
>    David Marchand
>
Thanks, I'll check those out and do a V2.

/Bruce