From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: [PATCH] build: mention -march in pkg-config description Date: Thu, 10 Jan 2019 17:28:06 +0000 Message-ID: <20190110172806.12952-1-bluca@debian.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: bruce.richardson@intel.com, christian.ehrhardt@canonical.com, Luca Boccassi , stable@dpdk.org To: dev@dpdk.org Return-path: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Applications need to at least match DPDK's -march option to build successfully due to some static inline functions in the public headers. This might cause problems, especially in distributions, so add a note in the pkg-config description. Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds") Cc: stable@dpdk.org Signed-off-by: Luca Boccassi --- At the moment there are no adversely affected applications in Debian and Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder are stand-alone DPDK-specific binaries), but we thought that having an explicit notice would be good. meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index f87dc235f..35126106a 100644 --- a/meson.build +++ b/meson.build @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(), libraries: dpdk_libraries, libraries_private: dpdk_drivers + dpdk_static_libraries + ['-Wl,-Bdynamic'] + dpdk_extra_ldflags, - description: 'The Data Plane Development Kit (DPDK)', + description: '''The Data Plane Development Kit (DPDK). +Note that CFLAGS might contain an -march flag higher than typical baseline. +This is required for a number of static inline functions in the public headers.''', subdirs: [get_option('include_subdir_arch'), '.'], extra_cflags: ['-include', 'rte_config.h'] + machine_args ) -- 2.20.1