From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH v4 1/2] mbuf: add function returning default
 buffer address
Date: Fri, 11 Jan 2019 11:09:38 +0000
Message-ID: <20190111110927.GB8355@minint-98vp2qg>
References: <20190109085426.39965-1-yskoh@mellanox.com>
 <20190110224030.2671-1-yskoh@mellanox.com>
 <CAJFAV8z9Ly6UVcMd67wpW6MupfYm6nzjzgNAgCUi+UUhLaXy1A@mail.gmail.com>
 <CAJFAV8xUQqK7az+0BubOTMUKSQ-SU79DAFZjq-V6Y+Yh5jjJEg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Thomas Monjalon <thomas@monjalon.net>, Olivier Matz
 <olivier.matz@6wind.com>, Shahaf Shuler <shahafs@mellanox.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "roszenrami@gmail.com" <roszenrami@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr40064.outbound.protection.outlook.com [40.107.4.64])
 by dpdk.org (Postfix) with ESMTP id 802EB1B94E
 for <dev@dpdk.org>; Fri, 11 Jan 2019 12:09:40 +0100 (CET)
In-Reply-To: <CAJFAV8xUQqK7az+0BubOTMUKSQ-SU79DAFZjq-V6Y+Yh5jjJEg@mail.gmail.com>
Content-Language: en-US
Content-ID: <EC037FDA4AB88240BB0FBBA3F476924D@eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jan 11, 2019 at 09:32:52AM +0100, David Marchand wrote:
> On Fri, Jan 11, 2019 at 9:11 AM David Marchand <david.marchand@redhat.com=
>
> wrote:
>=20
> > On Thu, Jan 10, 2019 at 11:40 PM Yongseok Koh <yskoh@mellanox.com> wrot=
e:
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> >
> >> index bc562dc8a9..5787616999 100644
> >> --- a/lib/librte_mbuf/rte_mbuf.h
> >> +++ b/lib/librte_mbuf/rte_mbuf.h
> >> @@ -788,8 +788,54 @@ rte_mbuf_from_indirect(struct rte_mbuf *mi)
> >>  }
> >>
> >>  /**
> >> + * Return the default buffer address of the mbuf.
> >>
> >
> > Nit: missed it... s/default //

Okay

> >
> > + *
> >> + * @warning
> >> + * @b EXPERIMENTAL: This API may change without prior notice.
> >> + * This will be used by rte_mbuf_to_baddr() which has redundant code =
once
> >> + * experimental tag is removed.
> >>
> >
> > Good point.
> > I wonder if we have a "todolist" for release n+2 so that we don't forge=
t
> > about such things to do.
> > Thomas ?
> >
>=20
> Maybe we could have something explicit in rte_mbuf_to_baddr that would
> avoid it "inherits" the experimental tag.
>=20
> @@ -844,9 +844,13 @@ struct rte_mbuf_ext_shared_info {
>  static inline char *
>  rte_mbuf_to_baddr(struct rte_mbuf *md)
>  {
> +#ifdef ALLOW_EXPERIMENTAL_API
> +       return rte_mbuf_buf_addr(md, md->pool);
> +#else
>         char *buffer_addr;
>         buffer_addr =3D (char *)md + sizeof(*md) +
> rte_pktmbuf_priv_size(md->pool);
>         return buffer_addr;
> +#endif

I like it, so that we can't forget to change it.

Yongseok