From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 3/6] net/tap: check interface name in kvargs
Date: Fri, 11 Jan 2019 11:49:17 -0800
Message-ID: <20190111114917.06da84bb@hermes.lan>
References: <20190111180659.5972-1-stephen@networkplumber.org>
 <20190111180659.5972-4-stephen@networkplumber.org>
 <14FED5CB-5C2B-452D-BD47-6303EF67F90A@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Wiles, Keith" <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com
 [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id E92251BB82
 for <dev@dpdk.org>; Fri, 11 Jan 2019 20:49:24 +0100 (CET)
Received: by mail-pf1-f195.google.com with SMTP id w73so7410164pfk.10
 for <dev@dpdk.org>; Fri, 11 Jan 2019 11:49:24 -0800 (PST)
In-Reply-To: <14FED5CB-5C2B-452D-BD47-6303EF67F90A@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 11 Jan 2019 19:37:00 +0000
"Wiles, Keith" <keith.wiles@intel.com> wrote:

> > +/* make sure name is a possible Linux network device name */
> > +static bool is_valid_iface(const char *name)  
> 
> I am sorry, but the function name must be on the next line as per the style. I know you do not like it, but that is what the style states.

I am surprised because most of the DPDK follows kernel style.
And in kernel style one line is preferred if line is not too long.