From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [dpdk-stable] [PATCH 2/2] build: use dependency() instead of find_library() Date: Fri, 11 Jan 2019 11:52:54 +0000 Message-ID: <20190111115254.GA3336@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190103175725.5836-2-bluca@debian.org> <20190107142812.GB14912@bricha3-MOBL.ger.corp.intel.com> <1546879174.6022.24.camel@debian.org> <20190107165552.GA23828@bricha3-MOBL.ger.corp.intel.com> <1547205028.4501.9.camel@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, stable@dpdk.org To: Luca Boccassi Return-path: Content-Disposition: inline In-Reply-To: <1547205028.4501.9.camel@debian.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 11, 2019 at 11:10:28AM +0000, Luca Boccassi wrote: > On Mon, 2019-01-07 at 16:55 +0000, Bruce Richardson wrote: > > On Mon, Jan 07, 2019 at 04:39:34PM +0000, Luca Boccassi wrote: > > > On Mon, 2019-01-07 at 14:28 +0000, Bruce Richardson wrote: > > > > On Thu, Jan 03, 2019 at 06:57:25PM +0100, Luca Boccassi wrote: > > > > > For libbsd, which is checked in a top level file and used to be > > > > > added > > > > > to the global linker flags array, add it to the ext_deps array > > > > > of > > > > > all top level meson files (app, test, lib, examples, drivers). > > > > > The > > > > > most correct change would be to let each individual > > > > > library/driver/app > > > > > depend on it individually if they use symbols from it, but it > > > > > would > > > > > diverge from the legacy Makefile's behaviour and make life a > > > > > bit > > > > > more > > > > > difficult for contributors. > > > > > > > > It shouldn't be necessary to add libbsd as a dependency for > > > > everything. I > > > > think just adding it as a dependency of EAL should work fine.  > > > > > > Won't that mean that the shared libraries other than EAL will have > > > undefined references? > > > > Should not happen. AFAIK when you link against a library in meson it > > will > > also link against any of that libraries dependencies too. For shared > > libraries meson always disallowed undefined references in the linker > > commandline. [To have libs with undefined refs, e.g. plugins, you > > need to > > use "shared_module" rather than "shared_library" command]. > > Looked at this again, and rte_cmdline is using strlcpy as well, and > it's built before rte_eal, so it fails: > > lib/76b5a35@@rte_cmdline@sta/librte_cmdline_cmdline_parse.c.o: In function `cmdline_complete': > cmdline_parse.c:(.text+0x861): undefined reference to `strlcpy' > > Adding it to ext_deps in both rte_cmdline and rte_eal works. Is that an acceptable compromise? > Sure. If eal has a dependency on cmdline, you probably don't need to add it as an external dependency to EAL too, but it doesn't really hurt to do so. /Bruce