From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3 2/4] build: use dependency() instead of find_library() Date: Fri, 11 Jan 2019 21:49:26 +0000 Message-ID: <20190111214925.GA13244@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190111162608.13162-1-bluca@debian.org> <20190111162608.13162-2-bluca@debian.org> <20190111172118.GB16340@bricha3-MOBL.ger.corp.intel.com> <1547230583.4501.21.camel@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Luca Boccassi Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DF7AD1BB40 for ; Fri, 11 Jan 2019 22:49:30 +0100 (CET) Content-Disposition: inline In-Reply-To: <1547230583.4501.21.camel@debian.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 11, 2019 at 06:16:23PM +0000, Luca Boccassi wrote: > On Fri, 2019-01-11 at 17:21 +0000, Bruce Richardson wrote: > > On Fri, Jan 11, 2019 at 04:26:06PM +0000, Luca Boccassi wrote: > > > Whenever possible (if the library ships a pkg-config file) use > > > meson's > > > dependency() function to look for it, as it will automatically add > > > it > > > to the Requires.private list if needed, to allow for static builds > > > to > > > succeed for reverse dependencies of DPDK. Otherwise the recursive > > > dependencies are not parsed, and users doing static builds have to > > > resolve them manually by themselves. > > > When using this API avoid additional checks that are superfluos and > > > > Spelling: superfluous > > I _always_ get that one wrong :-) > I often spell it as "unnecessary" to make life easier :-)