From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ye Xiaolong <xiaolong.ye@intel.com>
Subject: Re: [PATCH] vhost_user: remove statement for non-existed
	function
Date: Sat, 12 Jan 2019 09:01:59 +0800
Message-ID: <20190112010159.GA100283@intel.com>
References: <20190111080541.96774-1-xiaolong.ye@intel.com>
 <20190111133141.GA2026@dpdk-tbie.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
 xiao.w.wang@intel.com, stable@dpdk.org
To: Tiwei Bie <tiwei.bie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <20190111133141.GA2026@dpdk-tbie.sh.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 01/11, Tiwei Bie wrote:
>> vhost_user: remove statement for non-existed function
>
>s/vhost_user/vhost/
>
>On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote:
>> vhost_user_host_notifier_ctrl is not existed anymore, its statement in
>> header file should be removed accordingly.
>> 
>> Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
>> Cc: xiao.w.wang@intel.com
>> Cc: stable@dpdk.org
>
>There is no need to cc stable, because above commit is part
>of 19.02 which hasn't been released yet.
>
>For the rest,
>Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks for the review.
In this kind of case, I suppose there is no need to reroll the patch, right?

Thanks,
Xiaolong

>
>> 
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>>  lib/librte_vhost/vhost_user.h | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
>> index dc97be843..2a650fe4b 100644
>> --- a/lib/librte_vhost/vhost_user.h
>> +++ b/lib/librte_vhost/vhost_user.h
>> @@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
>>  /* vhost_user.c */
>>  int vhost_user_msg_handler(int vid, int fd);
>>  int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
>> -int vhost_user_host_notifier_ctrl(int vid, bool enable);
>>  
>>  /* socket.c */
>>  int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
>> -- 
>> 2.17.1
>>