From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v7 2/2] mbuf: implement generic format for sched field Date: Tue, 15 Jan 2019 15:11:51 -0800 Message-ID: <20190115151151.5105b80e@shemminger-XPS-13-9360> References: <20181219154237.836-1-reshma.pattan@intel.com> <20181220121609.16314-1-reshma.pattan@intel.com> <20181220121609.16314-2-reshma.pattan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, nikhil.rao@intel.com, olivier.matz@6wind.com, thomas@monjalon.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, konstantin.ananyev@intel.com To: Reshma Pattan Return-path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 1E9BBDE0 for ; Wed, 16 Jan 2019 00:11:54 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id b5so2016626plr.4 for ; Tue, 15 Jan 2019 15:11:54 -0800 (PST) In-Reply-To: <20181220121609.16314-2-reshma.pattan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 20 Dec 2018 12:16:09 +0000 Reshma Pattan wrote: > void > -rte_sched_port_pkt_write(struct rte_mbuf *pkt, > - uint32_t subport, uint32_t pipe, uint32_t traffic_class, > +rte_sched_port_pkt_write(struct rte_sched_port *port, > + struct rte_mbuf *pkt, > + uint32_t subport, uint32_t pipe, > + uint32_t traffic_class, > uint32_t queue, enum rte_meter_color color) Sorry I didn't notice this earlier, but changing the function signature like this is a complete ABI breakage. Old code will be passing different arguments than new code; therefore this change breaks both source and binary compatibility. Is 19.02 supposed to be an ABI/API breaking release? Or only an incremental update.