From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC] ethdev: add min/max MTU to device info Date: Wed, 16 Jan 2019 13:30:49 -0800 Message-ID: <20190116133049.029292da@shemminger-XPS-13-9360> References: <20180905164157.844-1-stephen@networkplumber.org> <2810348.XpGyddNB5W@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, ferruh.yigit@intel.com, arybchenko@solarflare.com To: Thomas Monjalon Return-path: Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 433DF1041 for ; Wed, 16 Jan 2019 22:30:53 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id z9so3692873pfi.2 for ; Wed, 16 Jan 2019 13:30:53 -0800 (PST) In-Reply-To: <2810348.XpGyddNB5W@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 19 Dec 2018 03:37:16 +0100 Thomas Monjalon wrote: > Hi Stephen, > > Can we expect a v2 of this patch? At least for removing deprecation > and bump ethdev version, etc? > > 05/09/2018 18:41, Stephen Hemminger: > > This addresses the usability issue raised by OVS at DPDK Userspace > > summit. It adds general min/max mtu into device info. For compatiablity, > > and to save space, it fits in a hole in existing structure. > > > > The initial version sets max mtu to normal Ethernet, it is up to > > PMD to set larger value if it supports Jumbo frames. > > > > Fixing the drivers to use this is trivial and can be done by 18.11. > > Already have some of the patches done. > > > > Signed-off-by: Stephen Hemminger > > > > It needs more than just this patch to be worthwhile. Need device drivers to fill in the max_mtu field, otherwise it would just break jumbo frame support. I suppose an initial patch to bump ethdev version would be possible for 19.05, are there other API changes doing that already for that relaease.