From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v5 2/4] build: use dependency() instead of find_library() Date: Tue, 22 Jan 2019 13:46:53 +0000 Message-ID: <20190122134653.GB29548@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190122131054.25196-1-bluca@debian.org> <20190122131054.25196-2-bluca@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Luca Boccassi Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A71CC25B3 for ; Tue, 22 Jan 2019 14:46:57 +0100 (CET) Content-Disposition: inline In-Reply-To: <20190122131054.25196-2-bluca@debian.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 22, 2019 at 01:10:52PM +0000, Luca Boccassi wrote: > Whenever possible (if the library ships a pkg-config file) use meson's > dependency() function to look for it, as it will automatically add it > to the Requires.private list if needed, to allow for static builds to > succeed for reverse dependencies of DPDK. Otherwise the recursive > dependencies are not parsed, and users doing static builds have to > resolve them manually by themselves. > When using this API avoid additional checks that are superfluous and > take extra time, and avoid adding the linker flag manually which causes > it to be duplicated. > > Signed-off-by: Luca Boccassi > --- > v2: split libbsd change in a separate commit, remove CC to stable > as a meson bump will be required > v4: update comment in drivers/meson.build to clarify role of > pkgconfig_extra_libs > v5: remove -lz from drivers/compress/zlib How is this removal possible? Does drivers/compress/zlib no longer depend on libz, or is there a dependency added somewhere else in this patch that I'm missing? Similar question with the -lcrypto removal? /Bruce