From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 0/5] remove usage of register keyword in C
Date: Thu, 31 Jan 2019 09:11:28 +0000
Message-ID: <20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com>
References: <20180731163059.27085-1-stephen@networkplumber.org>
 <20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3>
 <50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com>
 <20180801140356.5ac88c43@xeon-e3>
 <bebe7dd0-0a63-0f25-347b-be0c7517135f@intel.com>
 <a008965c-9e2b-0b67-866a-42f507e7bb97@intel.com>
 <2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Yongseok Koh <yskoh@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Tom Barbette <barbette@kth.se>
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 1A3871B415
 for <dev@dpdk.org>; Thu, 31 Jan 2019 10:11:33 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 31, 2019 at 09:02:36AM +0100, Tom Barbette wrote:
> Hi all,
> 
> Has there been any change regarding this? I'm still at DPDK 18.11. Maybe
> automatically add -Wno-register when C++17 is enabled? Or have a some
> register macro which gets undefined if C++17 is enabled?
> 
> The "warning: ISO C++1z does not allow ‘register’ storage class specifier"
> is annoying. And vim always goes to some DPDK header when ":make" fails
> because of the warning...
> 
> Thanks,
> Tom
> 
What header is that? From what I see the patchset only makes changes to .c
files rather than any .h files, so not sure it would help in your case.

For what it's worth on the general discussion, I'm in favour of applying
this patchset. I view marking variables as "register" as completely
unncessary. If someone can demonstrate a place where it actually makes a
difference, then we can keep that use of the keywork, otherwise I think the
code is as well off without it.

/Bruce