From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] hash: fix sprintf with snprintf Date: Wed, 6 Feb 2019 08:18:16 -0800 Message-ID: <20190206081816.648c0f12@hermes.lan> References: <1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, reshma.pattan@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, stable@dpdk.org To: Pallantla Poornima Return-path: Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id A76161B396 for ; Wed, 6 Feb 2019 17:18:25 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id e5so3299930plb.5 for ; Wed, 06 Feb 2019 08:18:25 -0800 (PST) In-Reply-To: <1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 6 Feb 2019 10:52:17 +0000 Pallantla Poornima wrote: > + snprintf(name, sizeof(name), "test_hash%d_data", > + hashtest_key_lens[table_index]); It looks like %u should be used since hashtest_key_lens is unsigned 32 bit value. Since the values in table are always small enough, I don't see why this should go to stable.