From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 0/3] Replace compilation time options with log level Date: Wed, 20 Feb 2019 15:08:23 -0800 Message-ID: <20190220150823.69a3cb3e@shemminger-XPS-13-9360> References: <20190220224714.16303-1-dharmik.thakkar@arm.com> <20190220230023.17029-1-dharmik.thakkar@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Dharmik Thakkar Return-path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 096361E34 for ; Thu, 21 Feb 2019 00:08:29 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id d25so4344380pfn.8 for ; Wed, 20 Feb 2019 15:08:28 -0800 (PST) In-Reply-To: <20190220230023.17029-1-dharmik.thakkar@arm.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 20 Feb 2019 17:00:20 -0600 Dharmik Thakkar wrote: > Currently, in test code, for printing extra information, > compilation time options are used. This approach does not compile the > code always. Macro needs to be set for the code to compile. > > This patchset replaces compilation time option with log level based > approach, thus enabling compilation of code always. Log levels can be > set using eal parameters. > > Dharmik Thakkar (3): > test/hash: replace macro with log-level approach > test/efd: enable unit test compilation always > test/timer: enable unit test compilation always > > test/test/test_efd.c | 24 ++++++++---------------- > test/test/test_hash.c | 3 +-- > test/test/test_timer_racecond.c | 23 ++++++++++------------- > 3 files changed, 19 insertions(+), 31 deletions(-) > Maybe the tests should use their own dynamic logging (i.e. --log-level=test.hash:debug)