From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiwei Bie Subject: Re: [PATCH] vhost: remove vhost-net requirements from generic vhost APIs Date: Mon, 25 Feb 2019 12:54:39 +0800 Message-ID: <20190225045438.GA31146@dpdk-tbie.sh.intel.com> References: <20190224233555.31304-1-darek.stojaczyk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com, Darek Stojaczyk To: Dariusz Stojaczyk Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0014F29C6 for ; Mon, 25 Feb 2019 05:54:41 +0100 (CET) Content-Disposition: inline In-Reply-To: <20190224233555.31304-1-darek.stojaczyk@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 25, 2019 at 12:35:55AM +0100, Dariusz Stojaczyk wrote: > From: Darek Stojaczyk > > The rte_vhost API to put data into virtqueues operates > on mbufs and hence it is strictly vhost-net specific. > External backends need to implement virtqueue handling > from scratch and that's just not possible without APIs > to get/set vring base addresses. > > Those relevant APIs are there, but they have a check that > prevents them from working with any non-vhost-net device. > This patch removes those checks. > > rte_vhost_get_log_base() is not necessarily needed for > external backends, as other, higher level vhost APIs for > live migration are available and could be used instead. > We remove the extra check from it anyway for consistency. > > Signed-off-by: Darek Stojaczyk > --- > lib/librte_vhost/vhost.c | 21 --------------------- > 1 file changed, 21 deletions(-) Reviewed-by: Tiwei Bie Thanks, Tiwei