From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 1/5] test/cmdline_test: move to app
 directory
Date: Tue, 26 Feb 2019 11:24:28 +0000
Message-ID: <20190226112427.GA284928@bricha3-MOBL.ger.corp.intel.com>
References: <20190125202642.66559-1-bruce.richardson@intel.com>
 <20190219145308.65668-1-bruce.richardson@intel.com>
 <20190219145308.65668-2-bruce.richardson@intel.com>
 <6358435.8ZjemOinAO@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 110C62BB8
 for <dev@dpdk.org>; Tue, 26 Feb 2019 12:24:38 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <6358435.8ZjemOinAO@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Feb 26, 2019 at 10:14:08AM +0100, Thomas Monjalon wrote:
> 19/02/2019 15:53, Bruce Richardson:
> > Move app to "app" directory and enable with meson build.
> > 
> > CC: Olivier Matz <olivier.matz@6wind.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  MAINTAINERS                                     | 2 +-
> >  app/Makefile                                    | 1 +
> >  {test => app}/cmdline_test/Makefile             | 0
> >  {test => app}/cmdline_test/cmdline_test.c       | 0
> >  {test => app}/cmdline_test/cmdline_test.h       | 0
> >  {test => app}/cmdline_test/cmdline_test.py      | 0
> >  {test => app}/cmdline_test/cmdline_test_data.py | 0
> >  {test => app}/cmdline_test/commands.c           | 0
> 
> Sorry, I didn't realize before,
> other test apps directories are named test-*.
> Shouldn't we name this one test-cmdline?
>
Looking into it now, changing the directory name is easy enough, however
the final binary produced is also called cmdline_test - should it be
changed too? Changing it would be a bit more invasive, and would be
user-visible (perhaps just to test suites), but would lead to more
consistency.

NOTE: this only applies to the "make" build, since the meson build uses the
directory name as the binary name, so it's already consistent. There is no
user visible change here, since the app wasn't available from meson builds
before.

My recommendation is therefore to rename the directory only, and leave the
binary name the same for make builds, given that when we switch completely
over to meson it will be consistent at that point.

Thoughts, Thomas?

/Bruce