From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH 0/4] Some fixes for vhost zero copy
Date: Wed, 27 Feb 2019 09:52:37 +0800
Message-ID: <20190227015237.GA21333@dpdk-tbie.sh.intel.com>
References: <20190222024209.30879-1-tiwei.bie@intel.com>
 <0ee272f4-ab82-b1b9-2735-434c2d40d229@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: zhihong.wang@intel.com, dev@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 4582A1E34
 for <dev@dpdk.org>; Wed, 27 Feb 2019 02:52:40 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <0ee272f4-ab82-b1b9-2735-434c2d40d229@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Feb 26, 2019 at 03:46:41PM +0100, Maxime Coquelin wrote:
> On 2/22/19 3:42 AM, Tiwei Bie wrote:
> > Tiwei Bie (4):
> >    vhost: restore mbuf first when freeing zmbuf
> >    vhost: fix potential use-after-free for zero copy mbuf
> >    vhost: fix potential use-after-free for memory region
> >    doc: improve vhost zero copy guide
> > 
> >   doc/guides/prog_guide/vhost_lib.rst |  3 +++
> >   lib/librte_vhost/vhost.h            | 34 +++++++++++++++++++++++
> >   lib/librte_vhost/vhost_user.c       | 42 ++++++++++++++++++++++-------
> >   lib/librte_vhost/virtio_net.c       | 34 -----------------------
> >   4 files changed, 70 insertions(+), 43 deletions(-)
> > 
> 
> Looking at the spec, I think we may need also to drain zmbufs in the
> VHOST_USER_SET_VRING_ENABLE for the disable case:
> 
> ""
> If VHOST_USER_F_PROTOCOL_FEATURES has been negotiated, the ring is
> initialized
> in a disabled state. Client must not pass data to/from the backend until
> ring is enabled by
> VHOST_USER_SET_VRING_ENABLE with parameter 1, or after it has been disabled
> by
> VHOST_USER_SET_VRING_ENABLE with parameter 0.
> 
> Each ring is initialized in a stopped state, client must not process it
> until
> ring is started, or *after it has been stopped*.
> ""
> 
> Do you take care of this or I send a patch on top?

Agree. Please feel free to send any patch on top.

Thanks!
Tiwei

> 
> Thanks,
> Maxime