From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver Date: Fri, 1 Mar 2019 10:31:25 -0800 Message-ID: <20190301103125.7f6f6b7e@shemminger-XPS-13-9360> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190301080947.91086-2-xiaolong.ye@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Qi Zhang To: Xiaolong Ye Return-path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 9A7F52B9E for ; Fri, 1 Mar 2019 19:31:30 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id l11so11806964pgq.10 for ; Fri, 01 Mar 2019 10:31:30 -0800 (PST) In-Reply-To: <20190301080947.91086-2-xiaolong.ye@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 1 Mar 2019 16:09:42 +0800 Xiaolong Ye wrote: > + if (umem->buffer) > + free(umem->buffer); Minor nit: you don't need to check for NULL free() already handles this.