From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 2/2] net/ice: disable advanced features in
 safe mode
Date: Fri, 1 Mar 2019 10:38:47 -0800
Message-ID: <20190301103847.64010d3f@shemminger-XPS-13-9360>
References: <20190301124613.66527-1-qiming.yang@intel.com>
 <20190301124613.66527-2-qiming.yang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Qiming Yang <qiming.yang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com
 [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 55F122C0C
 for <dev@dpdk.org>; Fri,  1 Mar 2019 19:38:52 +0100 (CET)
Received: by mail-pf1-f194.google.com with SMTP id d25so11803130pfn.8
 for <dev@dpdk.org>; Fri, 01 Mar 2019 10:38:52 -0800 (PST)
In-Reply-To: <20190301124613.66527-2-qiming.yang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri,  1 Mar 2019 20:46:13 +0800
Qiming Yang <qiming.yang@intel.com> wrote:

> +	PMD_INIT_LOG(WARNING, "Initialize in safe mode,"
> +		"some features are disabled.\n");

Don't split a message string, it makes it harder to search.

Also, most drivers define PMD_INIT_LOG to always add a newline and do
not add the newline in the macro call.