From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/2] net/ice: suppport package download Date: Fri, 1 Mar 2019 10:40:41 -0800 Message-ID: <20190301104041.166ae95a@shemminger-XPS-13-9360> References: <20190301124613.66527-1-qiming.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Qiming Yang Return-path: Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by dpdk.org (Postfix) with ESMTP id EB4FB2C38 for ; Fri, 1 Mar 2019 19:40:43 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id b65so8847245plb.6 for ; Fri, 01 Mar 2019 10:40:43 -0800 (PST) In-Reply-To: <20190301124613.66527-1-qiming.yang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 1 Mar 2019 20:46:12 +0800 Qiming Yang wrote: > + > + if (kvargs_count > 1) > + PMD_DRV_LOG(WARNING, "More than one argument \"%s\" and only " > + "the first invalid or last valid one is used !", Do not add line breaks to error message strings, it makes it harder to find them in the source with tools like grep