From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Santana Subject: [PATCH v4 2/2] devtools: fix result of svg include check Date: Mon, 4 Mar 2019 14:07:16 -0500 Message-ID: <20190304190716.5847-3-msantana@redhat.com> References: <20190301170806.3547-1-msantana@redhat.com> <20190304190716.5847-1-msantana@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: stable@dpdk.org, Bruce Richardson , Van Haaren Harry , ramirose@gmail.com, Thomas Monjalon To: dev@dpdk.org Return-path: In-Reply-To: <20190304190716.5847-1-msantana@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix trivial bug. In sh shell, 'foo = 1' is not the same as 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo as a command, rather than a simple variable assignment. Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks") Cc: stable@dpdk.org Signed-off-by: Michael Santana --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 7e862e0a4..521534fce 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -73,7 +73,7 @@ check_forbidden_additions() { # -v RET_ON_FAIL=1 \ -v MESSAGE='Using explicit .svg extension instead of .*' \ -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \ - "$1" || res = 1 + "$1" || res=1 return $res } -- 2.20.1