From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ye Xiaolong <xiaolong.ye@intel.com>
Subject: Re: [PATCH v1 2/6] lib/mbuf: enable parse flags when
 create mempool
Date: Thu, 7 Mar 2019 11:07:12 +0800
Message-ID: <20190307030712.GA42685@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190301080947.91086-3-xiaolong.ye@intel.com>
 <CAJFAV8yQvH-EW8Z1D+u-hvioDqozT=3-hs__AMp=2NB0UGN4Yg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev <dev@dpdk.org>, Qi Zhang <qi.z.zhang@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 926402C17
 for <dev@dpdk.org>; Thu,  7 Mar 2019 04:10:21 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <CAJFAV8yQvH-EW8Z1D+u-hvioDqozT=3-hs__AMp=2NB0UGN4Yg@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi David,

Thanks for you comments.

On 03/05, David Marchand wrote:
>On Fri, Mar 1, 2019 at 9:13 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>
>> This give the option that applicaiton can configure each
>> memory chunk's size precisely. (by MEMPOOL_F_NO_SPREAD).
>>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>>
>
>Cc: maintainer
>
>---
>>  lib/librte_mbuf/rte_mbuf.c | 15 ++++++++++++---
>>  lib/librte_mbuf/rte_mbuf.h |  8 +++++++-
>>  2 files changed, 19 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
>> index 21f6f7404..0f6fcff28 100644
>> --- a/lib/librte_mbuf/rte_mbuf.c
>> +++ b/lib/librte_mbuf/rte_mbuf.c
>> @@ -110,7 +110,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
>>  struct rte_mempool *
>>  rte_pktmbuf_pool_create_by_ops(const char *name, unsigned int n,
>>         unsigned int cache_size, uint16_t priv_size, uint16_t
>> data_room_size,
>> -       int socket_id, const char *ops_name)
>> +       unsigned int flags, int socket_id, const char *ops_name)
>>  {
>>         struct rte_mempool *mp;
>>         struct rte_pktmbuf_pool_private mbp_priv;
>>
>
>You can't do that, rte_pktmbuf_pool_create_by_ops is exposed to the user
>apps and part of the ABI.
>You must define a new internal fonction that takes this flag, keeps the
>existing interface and add your new experimental api.
>

In this case, if I define a new function that takes the flag, it seems would
have a lot of duplicated code with rte_pktmbuf_pool_create_by_ops, do you have
any suggestions for better handling?

Thanks,
Xiaolong

>
>-- 
>David Marchand