From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: [PATCH v2] devtools: fix meson build test to exit on failure Date: Tue, 12 Mar 2019 10:18:28 +0000 Message-ID: <20190312101828.18817-1-bruce.richardson@intel.com> References: <20190312100958.18751-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Bruce Richardson To: dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A7C3737B0 for ; Tue, 12 Mar 2019 11:18:33 +0100 (CET) In-Reply-To: <20190312100958.18751-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When piping the ninja command through cat, we lose the error value from the call to ninja in the case of failure. This prevents the script from exiting at the first broken build. Fix this by setting the "pipefail" shell option. Fixes: 4bcb9b768604 ("devtools: add verbose option to meson build test") Signed-off-by: Bruce Richardson --- V2: fix typo in commit message devtools/test-meson-builds.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index f82a0fd6c..9f5620583 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -7,6 +7,8 @@ # * if a build-directory already exists we assume it was properly configured # Run ninja after configuration is done. +set -o pipefail + srcdir=$(dirname $(readlink -f $0))/.. MESON=${MESON:-meson} use_shared="--default-library=shared" -- 2.20.1