From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH 1/2] examples/ethtool: remove query of default config Date: Wed, 13 Mar 2019 11:09:09 +0100 Message-ID: <20190313100910.31260-2-thomas@monjalon.net> References: <20190313100910.31260-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit To: dev@dpdk.org Return-path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 318734C9C for ; Wed, 13 Mar 2019 11:09:36 +0100 (CET) Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F832E46AB for ; Wed, 13 Mar 2019 06:09:34 -0400 (EDT) In-Reply-To: <20190313100910.31260-1-thomas@monjalon.net> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The default config is used if the setup parameter is NULL. No need to query the default config with rte_eth_dev_info_get(). The function call will be removed with another useless info. Signed-off-by: Thomas Monjalon --- examples/ethtool/ethtool-app/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c index dc93adfe3..e23d3afd2 100644 --- a/examples/ethtool/ethtool-app/main.c +++ b/examples/ethtool/ethtool-app/main.c @@ -95,7 +95,6 @@ static void setup_ports(struct app_config *app_cfg, int cnt_ports) char str_name[16]; uint16_t nb_rxd = PORT_RX_QUEUE_SIZE; uint16_t nb_txd = PORT_TX_QUEUE_SIZE; - struct rte_eth_txconf txconf; memset(&cfg_port, 0, sizeof(cfg_port)); cfg_port.txmode.mq_mode = ETH_MQ_TX_NONE; @@ -140,10 +139,9 @@ static void setup_ports(struct app_config *app_cfg, int cnt_ports) rte_exit(EXIT_FAILURE, "rte_eth_rx_queue_setup failed" ); - txconf = dev_info.default_txconf; if (rte_eth_tx_queue_setup( idx_port, 0, nb_txd, - rte_eth_dev_socket_id(idx_port), &txconf) < 0) + rte_eth_dev_socket_id(idx_port), NULL) < 0) rte_exit(EXIT_FAILURE, "rte_eth_tx_queue_setup failed" ); -- 2.20.1