From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [RFC PATCH 0/6] change legacy linuxapp/bsdapp names Date: Wed, 13 Mar 2019 15:02:57 +0000 Message-ID: <20190313150257.GA1175472@bricha3-MOBL.ger.corp.intel.com> References: <20190306162242.65375-1-bruce.richardson@intel.com> <19421689.NtES9yoMkj@xps> <2347388.E9kf87BXsl@xps> <851ec589-621b-c31e-7198-cd3b9e5ddd68@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 87DFF3772 for ; Wed, 13 Mar 2019 16:03:02 +0100 (CET) Content-Disposition: inline In-Reply-To: <851ec589-621b-c31e-7198-cd3b9e5ddd68@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 13, 2019 at 02:21:31PM +0000, Ferruh Yigit wrote: > On 3/13/2019 1:59 PM, Thomas Monjalon wrote: > > 13/03/2019 14:41, Ferruh Yigit: > >> On 3/12/2019 10:13 PM, Thomas Monjalon wrote: > >>>> Bruce Richardson (6): > >>>> eal/bsdapp: rename to freebsd > >>>> eal/linuxapp: rename to linux > >>>> build/linux: rename macro from LINUXAPP to LINUX > >>>> build/freebsd: rename macro from BSDPAPP to FREEBSD > >>>> build/meson: change linuxapp to linux in meson cross files > >>>> build: allow linux and freebsd in build configs > >>> > >>> Applied, thanks > >> > >> This has potential to break some automation/scripts since changes the names of > >> the config files: > >> 'make T=x86_64-native-linuxapp-gcc config' becomes > >> 'make T=x86_64-native-linux-gcc config' etc... > >> > >> I suggest highlighting this change in release notes! > > > > No, the old names should still work. > > Otherwise, it would be an API breakage, which is very bad! > > > > Ah, right config is working, how I hit this is: > > $ make T=x86_64-native-linuxapp-gcc cscope > Invalid config: x86_64-native-linuxapp-gcc > > 'cscope' (and friends) also should be covered ... Ok, the root cause of this is that even though the build-tags function does not use the config, it checks if the config parameter passed in is a valid one by running "make showconfig". This I changed to filter out the old configs so they are not advertised any more - though they still work - which causes build-tags to assume that the config is invalid. I therefore suggest we fix this by changing the check for a valid config to check if there is a defconfig_ file with the same name rather than asking showconfig. /Bruce