From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 1/3] rwlock: reimplement with atomic
 builtins
Date: Thu, 14 Mar 2019 08:54:29 -0700
Message-ID: <20190314085429.22ccd9ca@shemminger-XPS-13-9360>
References: <1552569304-74817-1-git-send-email-joyce.kong@arm.com>
 <1552569304-74817-2-git-send-email-joyce.kong@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, nd@arm.com, Gavin Hu <gavin.hu@arm.com>,
 jerinj@marvell.com, konstantin.ananyev@intel.com,
 chaozhu@linux.vnet.ibm.com, bruce.richardson@intel.com,
 thomas@monjalon.net, hemant.agrawal@nxp.com, honnappa.nagarahalli@arm.com
To: Joyce Kong <joyce.kong@arm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com
 [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 7B2BD324D
 for <dev@dpdk.org>; Thu, 14 Mar 2019 16:54:33 +0100 (CET)
Received: by mail-pg1-f193.google.com with SMTP id q206so4271786pgq.4
 for <dev@dpdk.org>; Thu, 14 Mar 2019 08:54:33 -0700 (PDT)
In-Reply-To: <1552569304-74817-2-git-send-email-joyce.kong@arm.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 14 Mar 2019 21:15:02 +0800
Joyce Kong <joyce.kong@arm.com> wrote:

> -		success = rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt,
> -					      (uint32_t)x, (uint32_t)(x + 1));
> +		success = __atomic_compare_exchange_n(&rwl->cnt, &x, x+1, 1,
> +					__ATOMIC_ACQUIRE, __ATOMIC_RELAXED);

Would it be possible to have rte_atomic32_cmpset be an inline function
that became __atomic_comppare_exchange? Then all usages would be the same.