From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2 1/4] power: fix non thread-safe power env modification Date: Mon, 18 Mar 2019 08:01:50 -0700 Message-ID: <20190318080150.62154337@shemminger-XPS-13-9360> References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: david.hunt@intel.com, dev@dpdk.org, stable@dpdk.org To: Hajkowski Return-path: Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id DCEF62C60 for ; Mon, 18 Mar 2019 16:01:55 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id v21so11429183pfm.12 for ; Mon, 18 Mar 2019 08:01:55 -0700 (PDT) In-Reply-To: <20190318115647.14784-1-marcinx.hajkowski@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 18 Mar 2019 12:56:44 +0100 Hajkowski wrote: > From: Marcin Hajkowski > > Due to lack of thread safety in exisiting solution > use spinlock mechanism for atomic > modification of power environment related data. > > Fixes: 445c6528b5 ("power: common interface for guest and host") > Cc: stable@dpdk.org > > Signed-off-by: Marcin Hajkowski Thanks for making this library better. When I did the dpdk-metrics investigation at the US DPDK summit, the power library was one of the DPDK libraries that no upstream open source project uses. You might want to consider: * why is no project using it? what is wrong? * does it not fit any use case in any project should it continue? * if it is for a non-open source customer, then why is it part of DPDK?